Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take into account units for comparisons between Column and Quantity #8904

Merged
merged 1 commit into from
Jun 23, 2019

Conversation

mhvk
Copy link
Contributor

@mhvk mhvk commented Jun 22, 2019

This was already the case for regular operations such as addition.

fixes #6532

This was already the case for regular operations such as addition.
@mhvk mhvk added this to the v3.2.2 milestone Jun 22, 2019
@mhvk mhvk requested a review from taldcroft June 22, 2019 01:35
Copy link
Member

@taldcroft taldcroft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@taldcroft taldcroft merged commit 5e3b3f2 into astropy:master Jun 23, 2019
@mhvk mhvk deleted the column-quantity-comparison branch June 23, 2019 12:02
bsipocz pushed a commit that referenced this pull request Jun 25, 2019
Take into account units for comparisons between Column and Quantity
bsipocz added a commit that referenced this pull request Oct 24, 2019
Partial revert of #8904 for MaskedArray and numpy <= 1.15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression with Column and units ?
2 participants