feat: add extra_user_agents to BaseVOQuery#3526
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3526 +/- ##
=======================================
Coverage 72.39% 72.40%
=======================================
Files 219 219
Lines 20432 20436 +4
=======================================
+ Hits 14792 14796 +4
Misses 5640 5640 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
40dd093 to
ca66a07
Compare
bsipocz
left a comment
There was a problem hiding this comment.
This looks all good, thanks!
(I'm not sure if you've seen, but Markus also changed the user agent in pyvo; though of course that is not yet usable for astroquery purposes (will be released in pyvo 1.9 and it will take some time for that version to be the minimum requirement)
|
Thanks for the merge! I've seen Markus's changes and his suggestions for a standard user agent that'd tell VO services that the current user is doing actual science. We all have huge load issues these days, this might help? 🤞 |
This PR fixes #3507
Might not be the best way to do it, I was a bit unsure.
There will be a following PR documenting its use in the
SimbadClassbut I thought that it would be best to separate these changes.