Skip to content

feat: add extra_user_agents to BaseVOQuery#3526

Merged
bsipocz merged 1 commit into
astropy:mainfrom
cds-astro:add-user-agent-in-basevoquery
Feb 11, 2026
Merged

feat: add extra_user_agents to BaseVOQuery#3526
bsipocz merged 1 commit into
astropy:mainfrom
cds-astro:add-user-agent-in-basevoquery

Conversation

@ManonMarchand
Copy link
Copy Markdown
Member

This PR fixes #3507

Might not be the best way to do it, I was a bit unsure.

There will be a following PR documenting its use in the SimbadClass but I thought that it would be best to separate these changes.

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 11, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.40%. Comparing base (e1aa370) to head (ca66a07).
⚠️ Report is 185 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3526   +/-   ##
=======================================
  Coverage   72.39%   72.40%           
=======================================
  Files         219      219           
  Lines       20432    20436    +4     
=======================================
+ Hits        14792    14796    +4     
  Misses       5640     5640           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ManonMarchand ManonMarchand force-pushed the add-user-agent-in-basevoquery branch from 40dd093 to ca66a07 Compare February 11, 2026 12:35
Copy link
Copy Markdown
Member

@bsipocz bsipocz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks all good, thanks!

(I'm not sure if you've seen, but Markus also changed the user agent in pyvo; though of course that is not yet usable for astroquery purposes (will be released in pyvo 1.9 and it will take some time for that version to be the minimum requirement)

@bsipocz bsipocz added this to the 0.4.12 milestone Feb 11, 2026
@bsipocz bsipocz added the query astroquery internals label Feb 11, 2026
@bsipocz bsipocz merged commit 7ba4994 into astropy:main Feb 11, 2026
11 of 12 checks passed
@ManonMarchand ManonMarchand deleted the add-user-agent-in-basevoquery branch February 12, 2026 10:12
@ManonMarchand
Copy link
Copy Markdown
Member Author

Thanks for the merge!

I've seen Markus's changes and his suggestions for a standard user agent that'd tell VO services that the current user is doing actual science. We all have huge load issues these days, this might help? 🤞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement query astroquery internals

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Extra user-agents in BaseVOQuery

2 participants