Proposed SIMBAD sub-package #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I like it. As with the other tools in the package, we need more examples in the docs, and similarly it would be nice to make the interfaces more uniform, but until we do that everywhere, I see no reason not to include this code as it stands. @astrofrog, agree? |
Member
|
I agree, we haven't settled on a consistent API yet, so let's just include it for now and then try to make everything uniform later. |
keflavich
added a commit
to eas342/astroquery
that referenced
this pull request
Mar 25, 2025
# This is the 1st commit message: I made a lot of tests using AI help - I think it's all right, but I want to review it on github & see what coverage bot says # This is the commit message astropy#2: consolidated tests & expanded to cover `head_safe` cases # This is the commit message astropy#3: remove some cruft # This is the commit message astropy#4: cleanup: remove unused file # This is the commit message astropy#5: some cleanup of flake8 - but the AI choked on the easy task, so I'm not sure things are right any more... # This is the commit message astropy#6: cover the zero-size initial file case # This is the commit message astropy#7: a lot of refactoring because some tests were failing, there were some redundant checks, and there seems to be no reason to return None # This is the commit message astropy#8: compress test parameters and add `cache` to increase coverage # This is the commit message astropy#9: add a note about an uncovered case # This is the commit message astropy#10: flake # This is the commit message astropy#11: add changelog entry # This is the commit message astropy#12: add tests for log level (to test progressbar) # This is the commit message astropy#13: add back removed tests # This is the commit message astropy#14: whitespace # This is the commit message astropy#15: raise an exception if we find a cached file we can't validate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So, as announced on the mailing list, here is the code I use to query the SIMBAD database.
There's still work to be done, mainly on the documentation side, but it's working, at least for me. The interface is quite different from already included subpackages, so I guess we'll need to discuss on the way to harmonize this.