Skip to content

Conversation

@migueldvb
Copy link
Member

This modifies the HITRAN module to follow the common class based API specification. It does not
support yet any output format description apart from the the 160-byte fixed-width format used in HITRAN 2004. I think that support for user-defined formats could be added in a different PR.

fixes #824

@astropy-bot
Copy link

astropy-bot bot commented Jan 19, 2018

Hi there @migueldvb 👋 - thanks for the pull request! I'm just a friendly 🤖 that checks for issues related to the changelog and making sure that this pull request is milestoned and labeled correctly. This is mainly intended for the maintainers, so if you are not a maintainer you can ignore this, and a maintainer will let you know if any action is required on your part 😃.

I noticed the following issue with this pull request:

  • Changelog entry not present (or pull request number missing) and neither the Affects-dev nor the no-changelog-entry-needed label are set

Would it be possible to fix this? Thanks!

If there are any issues with this message, please report them here.

@migueldvb migueldvb force-pushed the hitran branch 2 times, most recently from d3644ea to b3584b1 Compare January 19, 2018 22:28
@migueldvb
Copy link
Member Author

I forgot to add the Changelog file to the PR. I think everything should be there now.

@keflavich
Copy link
Contributor

Awesome, looks good. I gave it a once-over and approve, but I should read more carefully before giving official approval.

@codecov
Copy link

codecov bot commented Jan 20, 2018

Codecov Report

Merging #1028 into master will increase coverage by 0.18%.
The diff coverage is 80.95%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1028      +/-   ##
==========================================
+ Coverage   63.97%   64.16%   +0.18%     
==========================================
  Files         143      144       +1     
  Lines       11348    11362      +14     
==========================================
+ Hits         7260     7290      +30     
+ Misses       4088     4072      -16
Impacted Files Coverage Δ
astroquery/hitran/__init__.py 100% <100%> (ø) ⬆️
astroquery/hitran/utils.py 57.5% <57.5%> (ø)
astroquery/hitran/core.py 94.54% <94.54%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5405989...966ea40. Read the comment docs.

@migueldvb migueldvb force-pushed the hitran branch 2 times, most recently from 6ce9e85 to 2dab28e Compare January 25, 2018 00:36
@migueldvb migueldvb force-pushed the hitran branch 2 times, most recently from 8660701 to c6109c0 Compare February 4, 2018 16:50
@keflavich
Copy link
Contributor

It looks like there's one legit failure, hitran seems not to be indexed:
https://travis-ci.org/astropy/astroquery/jobs/337249515#L2012

This issue: https://travis-ci.org/astropy/astroquery/jobs/337249517 is probably not real, but some sort of travis configuration issue.

@migueldvb
Copy link
Member Author

migueldvb commented Feb 13, 2018

oh yes, I'll fix the linking of hitran in the docs and see if this solves the failure.

EDIT: the docs build problem is gone.

@migueldvb migueldvb force-pushed the hitran branch 2 times, most recently from 6245577 to 59b4a74 Compare February 13, 2018 03:32
@bsipocz bsipocz added the hitran label Feb 13, 2018
@bsipocz bsipocz added this to the v0.3.8 milestone Feb 13, 2018
@migueldvb migueldvb force-pushed the hitran branch 2 times, most recently from 55a6c10 to f07e00d Compare March 26, 2018 18:32
@bsipocz
Copy link
Member

bsipocz commented Apr 23, 2018

@migueldvb - There is a minor conflict, would you mind to rebase?

@migueldvb
Copy link
Member Author

I rebased this branch. Hopefully all the CI checks will pass after the rebase!

@keflavich
Copy link
Contributor

@migueldvb Could you rebase this once more? @bsipocz just finished fixing our tests, so we will finally be able to safely merge this. It looks ready to merge to me.

@keflavich keflavich modified the milestones: v0.3.8, v0.3.9 Apr 27, 2018
@migueldvb
Copy link
Member Author

Sorry that I missed fixing this for 0.3.8. This is now rebased on master.

@keflavich keflavich merged commit 966ea40 into astropy:master May 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

HITRAN to use class based API

3 participants