-
-
Notifications
You must be signed in to change notification settings - Fork 425
Update HITRAN module to use class-based query API #1028
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi there @migueldvb 👋 - thanks for the pull request! I'm just a friendly 🤖 that checks for issues related to the changelog and making sure that this pull request is milestoned and labeled correctly. This is mainly intended for the maintainers, so if you are not a maintainer you can ignore this, and a maintainer will let you know if any action is required on your part 😃. I noticed the following issue with this pull request:
Would it be possible to fix this? Thanks! If there are any issues with this message, please report them here. |
d3644ea to
b3584b1
Compare
|
I forgot to add the Changelog file to the PR. I think everything should be there now. |
|
Awesome, looks good. I gave it a once-over and approve, but I should read more carefully before giving official approval. |
Codecov Report
@@ Coverage Diff @@
## master #1028 +/- ##
==========================================
+ Coverage 63.97% 64.16% +0.18%
==========================================
Files 143 144 +1
Lines 11348 11362 +14
==========================================
+ Hits 7260 7290 +30
+ Misses 4088 4072 -16
Continue to review full report at Codecov.
|
6ce9e85 to
2dab28e
Compare
8660701 to
c6109c0
Compare
|
It looks like there's one legit failure, hitran seems not to be indexed: This issue: https://travis-ci.org/astropy/astroquery/jobs/337249517 is probably not real, but some sort of travis configuration issue. |
|
oh yes, I'll fix the linking of hitran in the docs and see if this solves the failure. EDIT: the docs build problem is gone. |
6245577 to
59b4a74
Compare
55a6c10 to
f07e00d
Compare
|
@migueldvb - There is a minor conflict, would you mind to rebase? |
|
I rebased this branch. Hopefully all the CI checks will pass after the rebase! |
|
@migueldvb Could you rebase this once more? @bsipocz just finished fixing our tests, so we will finally be able to safely merge this. It looks ready to merge to me. |
|
Sorry that I missed fixing this for 0.3.8. This is now rebased on master. |
This modifies the HITRAN module to follow the common class based API specification. It does not
support yet any output format description apart from the the 160-byte fixed-width format used in HITRAN 2004. I think that support for user-defined formats could be added in a different PR.
fixes #824