Skip to content

Conversation

@keflavich
Copy link
Contributor

especially the DR ID

@astropy-bot
Copy link

astropy-bot bot commented Apr 25, 2018

Hi there @keflavich 👋 - thanks for the pull request! I'm just a friendly 🤖 that checks for issues related to the changelog and making sure that this pull request is milestoned and labeled correctly. This is mainly intended for the maintainers, so if you are not a maintainer you can ignore this, and a maintainer will let you know if any action is required on your part 😃.

Everything looks good from my point of view! 👍

If there are any issues with this message, please report them here.

@pep8speaks
Copy link

pep8speaks commented Apr 25, 2018

Hello @keflavich! Thanks for updating the PR.

Cheers ! There are no PEP8 issues in this Pull Request. 🍻

Comment last updated on April 26, 2018 at 00:42 Hours UTC

@codecov
Copy link

codecov bot commented Apr 25, 2018

Codecov Report

Merging #1112 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1112      +/-   ##
==========================================
+ Coverage   64.46%   64.47%   +<.01%     
==========================================
  Files         139      139              
  Lines       11153    11156       +3     
==========================================
+ Hits         7190     7193       +3     
  Misses       3963     3963
Impacted Files Coverage Δ
astroquery/gaia/core.py 82.47% <100%> (+0.18%) ⬆️
astroquery/gaia/__init__.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d143ed...a5477e6. Read the comment docs.

Copy link
Member

@bsipocz bsipocz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, except that it needs a changelog entry.

@keflavich keflavich merged commit 702cdaf into astropy:master Apr 26, 2018
@keflavich keflavich deleted the gaia_dr2_configitem branch April 26, 2018 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants