Skip to content

Conversation

@keflavich
Copy link
Contributor

cc @bsipocz. See #1115.

@astropy-bot
Copy link

astropy-bot bot commented Apr 27, 2018

Hi there @keflavich 👋 - thanks for the pull request! I'm just a friendly 🤖 that checks for issues related to the changelog and making sure that this pull request is milestoned and labeled correctly. This is mainly intended for the maintainers, so if you are not a maintainer you can ignore this, and a maintainer will let you know if any action is required on your part 😃.

I noticed the following issues with this pull request:

  • The milestone has not been set (this can only be set by a maintainer)
  • Changelog entry not present (or pull request number missing) and neither the Affects-dev nor the no-changelog-entry-needed label are set

Would it be possible to fix these? Thanks!

If there are any issues with this message, please report them here.

@codecov
Copy link

codecov bot commented Apr 27, 2018

Codecov Report

Merging #1124 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1124      +/-   ##
==========================================
- Coverage   63.97%   63.96%   -0.02%     
==========================================
  Files         143      143              
  Lines       11348    11355       +7     
==========================================
+ Hits         7260     7263       +3     
- Misses       4088     4092       +4
Impacted Files Coverage Δ
astroquery/mast/core.py 72.4% <0%> (-0.34%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4fe67df...372248e. Read the comment docs.

@keflavich
Copy link
Contributor Author

How do we test this?

.travis.yml Outdated
- stage: deploy
deploy:
provider: pypi
user: "keflavich"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we want maybe to set up an auto deploy user that will only have access to astroquery rather your whole pypi?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could do that for sure. I guess we can just set up a user called 'astroquery'?

@bsipocz
Copy link
Member

bsipocz commented May 4, 2018

@keflavich - I'm not sure, the best test probably to try out. There is a PR suitable to be merged right now, so we can use it.
Also, probably we'll need fine tuning, as currently the deploy stage won't run as master is always failing with the remote ones. But that's just a shuffle around jobs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants