-
-
Notifications
You must be signed in to change notification settings - Fork 425
Deploy dev to pypi from travis #1124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi there @keflavich 👋 - thanks for the pull request! I'm just a friendly 🤖 that checks for issues related to the changelog and making sure that this pull request is milestoned and labeled correctly. This is mainly intended for the maintainers, so if you are not a maintainer you can ignore this, and a maintainer will let you know if any action is required on your part 😃. I noticed the following issues with this pull request:
Would it be possible to fix these? Thanks! If there are any issues with this message, please report them here. |
Codecov Report
@@ Coverage Diff @@
## master #1124 +/- ##
==========================================
- Coverage 63.97% 63.96% -0.02%
==========================================
Files 143 143
Lines 11348 11355 +7
==========================================
+ Hits 7260 7263 +3
- Misses 4088 4092 +4
Continue to review full report at Codecov.
|
|
How do we test this? |
.travis.yml
Outdated
| - stage: deploy | ||
| deploy: | ||
| provider: pypi | ||
| user: "keflavich" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we want maybe to set up an auto deploy user that will only have access to astroquery rather your whole pypi?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could do that for sure. I guess we can just set up a user called 'astroquery'?
|
@keflavich - I'm not sure, the best test probably to try out. There is a PR suitable to be merged right now, so we can use it. |
cc @bsipocz. See #1115.