Allow non image data to be retrieved #2158
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Non image data (e.g. visibilities) will not have a 'cutout_service' in the datalink response but will have an 'async_service'. As this is also present for all image data we should use this unless we are requesting cutouts (which we will add to our astroquery module in the future). In addition I have fixed a bug where if there were no files that the user had access to it would give an obscure error when they were asked to be staged.
Codecov Report
@@ Coverage Diff @@
## main #2158 +/- ##
==========================================
+ Coverage 66.22% 66.24% +0.02%
==========================================
Files 419 419
Lines 28101 28118 +17
==========================================
+ Hits 18609 18626 +17
Misses 9492 9492
Continue to review full report at Codecov.
|
keflavich
approved these changes
Sep 27, 2021
bsipocz
approved these changes
Sep 28, 2021
Member
|
Thanks @jd-au! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Non image data (e.g. visibilities) will not have a 'cutout_service' in the datalink response but will have an 'async_service'. As this is also present for all image data we should use this unless we are requesting cutouts (which we will add to our astroquery module in the future).
In addition I have fixed a bug where if there were no files that the user had access to it would give an obscure error when they were asked to be staged.