Skip to content

Conversation

@bsipocz
Copy link
Member

@bsipocz bsipocz commented Nov 11, 2021

Maybe this will help to lessen the annoying coverage report flukes

@codecov
Copy link

codecov bot commented Nov 11, 2021

Codecov Report

Merging #2201 (1cdd0ce) into main (bc722c9) will decrease coverage by 4.30%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2201      +/-   ##
==========================================
- Coverage   66.11%   61.81%   -4.31%     
==========================================
  Files         418      129     -289     
  Lines       28180    16285   -11895     
==========================================
- Hits        18631    10066    -8565     
+ Misses       9549     6219    -3330     
Impacted Files Coverage Δ
astroquery/utils/tests/test_timer.py
astroquery/fermi/tests/test_fermi.py
astroquery/imcce/tests/test_skybot.py
astroquery/ipac/irsa/sha/__init__.py
astroquery/vamdc/tests/setup_package.py
astroquery/esa/xmm_newton/__init__.py
astroquery/__init__.py
astroquery/lamda/__init__.py
astroquery/esa/iso/tests/__init__.py
astroquery/ipac/ned/__init__.py
... and 279 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc722c9...1cdd0ce. Read the comment docs.

@bsipocz
Copy link
Member Author

bsipocz commented Nov 12, 2021

@pllim - could you spot any reasons why e.g. astroquery/simbad/tests/test_simbad.py wasn't skipped by this config? The same syntax seems to work for astropy.

@pllim
Copy link
Member

pllim commented Nov 12, 2021

You might need to copy or move the conftest.py file to root level. Right now, it is under astroquery package folder.

@bsipocz
Copy link
Member Author

bsipocz commented Nov 12, 2021

OK, so the config file has to be actually specified in the tox line. The full report now looks OK, I'm not sure why the comment is still messy, but hopefully, it will converge to something sensible once this is merged.

@bsipocz bsipocz merged commit 0fb3a9b into astropy:main Nov 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants