Skip to content

Conversation

@keflavich
Copy link
Contributor

The get_data_info and is_proprietary methods triggers a deprecation warning:

WARNING: AstropyDeprecationWarning: Using the table property is deprecated. Please use se to_table() instead. [pyvo.dal.query]

This fixes the issue.

@keflavich keflavich added the alma label Nov 12, 2021
@bsipocz bsipocz added this to the v0.4.4 milestone Nov 12, 2021
@bsipocz
Copy link
Member

bsipocz commented Nov 12, 2021

Thanks, @keflavich! Test failure is related, but once it's all green merge it away.

@codecov
Copy link

codecov bot commented Nov 12, 2021

Codecov Report

Merging #2207 (ee6d53b) into main (bc722c9) will decrease coverage by 4.31%.
The diff coverage is 20.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2207      +/-   ##
==========================================
- Coverage   66.11%   61.80%   -4.32%     
==========================================
  Files         418      129     -289     
  Lines       28180    16287   -11893     
==========================================
- Hits        18631    10066    -8565     
+ Misses       9549     6221    -3328     
Impacted Files Coverage Δ
astroquery/alma/core.py 36.65% <20.00%> (-0.14%) ⬇️
astroquery/alma/tests/test_alma.py
astroquery/ipac/irsa/ibe/tests/test_ibe.py
astroquery/hitran/setup_package.py
astroquery/splatalogue/tests/test_utils.py
astroquery/gama/__init__.py
astroquery/sdss/tests/test_sdss_remote.py
astroquery/skyview/tests/test_skyview_remote.py
...ipac/irsa/irsa_dust/tests/test_irsa_dust_remote.py
astroquery/ipac/irsa/__init__.py
... and 280 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc722c9...ee6d53b. Read the comment docs.

@bsipocz bsipocz merged commit b31f9d9 into astropy:main Nov 12, 2021
@bsipocz
Copy link
Member

bsipocz commented Nov 12, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants