Skip to content

Conversation

@jwoillez
Copy link
Member

Addresses #434

@keflavich
Copy link
Contributor

Can you explain the motivation for changing __session to _session? Also, what was the motivation for __session in the first place?

@jwoillez
Copy link
Member Author

The initial motivation for the private __session was really to hide it as much as possible from the developer. Nothing more.

NB: I have no way of testing the clean-ups I made on the commits above (poor internet connection).

@keflavich
Copy link
Contributor

OK, I'll test before merging

@jwoillez
Copy link
Member Author

Fingers crossed, then!

I also had some invasive changes on caching and on retrieve_data(), but lost them with a wrong git checkout. Caching seemed like the most problematic. There is a mix of suspend_cache() and cache=True/False throughout the code. We should settle on only one mechanism.

I will open issues for both. We can discuss there...

@keflavich
Copy link
Contributor

Passed locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants