Check response status code and raise if it is an error

[bsipocz]

Would it make sense to check the response status for a query? If a client/server error is returned, it may be useful to raise an exception rather than return it as a valid result.

[keflavich]

I think this can just be response.raise_for_status(), you don't need the if statement or anything. At least, I thought that's what raise_for_status was supposed to do (raise an exception if status is bad, else pass)

[bsipocz]

@keflavich - indeed, it works like that. Thanks.

[keflavich]

Yes, I think this is a good idea.

[bsipocz]

@keflavich - Addresed your comment. Does it need a changlog entry?

[keflavich]

Sure, call it a bugfix: this should have been the behavior all along.

[keflavich]

It looks like the MockResponse objects need a raise_for_status method too

[bsipocz]

Fixed. It's a wonder how it passed locally before I opened the PR.

[coveralls]

Coverage increased (+0.01%) to 66.62% when pulling eeaf478 on bsipocz:utils_check_response_status_code into ac827c9 on astropy:master.