-
-
Notifications
You must be signed in to change notification settings - Fork 425
Add new Gallery example and utilities for ALMA #498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I can't reproduce any of the failures locally. What happened to the configuration system?! |
|
@astrofrog - do you have any clues about what broke here? I didn't make any changes in astroquery that were relevant, but something in the astropy config system changed, and I don't understand what it is. I looked into this last week but had to give up on it for lack of time. |
|
@mdboom this has become the merge point for the broken configuration system in astroquery. I'm completely lost about how some of the errors are coming about; it looks like configurations in some sub-packages are being read by other sub-packages. Tom R pointed me to you - if you have any tips for cleaning up a gigantically broken config system, I could use them. |
|
The configuration system was overhauled in version 0.4, but the pre-0.3 API is still present and should work, although it emits AstropyDeprecationWarnings. It's possible that astropy/astropy@7186664 inadvertently broke things for people on the old config API. You could experiment with reverting that change to see if it resolves things for you. If so, let me know, and I'll revert it over on astropy master. ced65d5 doesn't make much sense to me -- where are the kwargs I'd start here for info about how to move from the old to the new API: http://docs.astropy.org/en/stable/config/config_0_4_transition.html |
|
Thanks @mdboom. Everything on astroquery builds fine on astropy/astropy@4f6b9b1 (the parent of astropy/astropy@7186664), at least on astroquery/master. I don't really know where some of the config items are coming from... I'll blame them, and if it's from me, then it was a different me. |
a9485fb to
5ff89bc
Compare
|
@mdboom the |
|
Sorry for the confusion about I'll fix the problem created in astropy/astropy@7186664 on astropy master. That should fix the legacy configuration API. You can then migrate to the new API when ready rather than under duress :) |
|
See astropy/astropy#3627. |
Add new Gallery example and utilities for ALMA
In preparation for the ALMA deadline... a nice example showing ALMA primary beam FOVs overlaid on a 2MASS image