-
-
Notifications
You must be signed in to change notification settings - Fork 425
Add HEASARC service #523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add HEASARC service #523
Conversation
|
Here's a link for the Batch Browse interface, with an example: https://heasarc.gsfc.nasa.gov/W3Browse/w3batchinfo.html |
|
@leyder, @keflavich and I hacked on this some more, and the basic example of getting a list of available datasets for a given target / mission works. There's a ton left to do, but maybe this can be done in future pull requests? Or does someone want to continue working on this one and make a pull request against this one? |
astroquery/heasarc/core.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The indent here is wrong, and I guess you got the sphinx failure because of that.
|
@abigailStev @kalgash82 @leyder @keflavich I've cleaned this up a bit (removing all the non-implemented methods and tests). If one of you is still working on this and plans to make a PR against this PR, please let me know. If not my suggestion would be to merge this as a bare-bones initial version and then anyone can add to it in new PRs against I didn't include a local test because the response is just a plain FITS file and we currently don't do any processing on it, so there's really no use in putting that in a file in the repo. |
|
@abigailStev @kalgash82 @leyder @keflavich thanks a lot! I can work on it during the next few weeks at some different active levels, but with the idea of having something really useful before the end of May. I don't mind forking your branch and then doing the PR to yours or doing it directly to the astroquery. Whatever is more convenient for you (maybe the second?) |
|
Is there anything we can test locally? For this first implementation, I guess 'no' - that's OK, even though coveralls will whine. |
|
@keflavich, by locally do you mean with no url connection? using a local database? If really important to check, I could make it happen, I think. At least for testing purposes, nothing else. |
|
@kalgash82 Yes, that's what I mean. The "problem" right now is that everything is so straightforward that we'd be testing more of the monkeypatching than the actual query code. |
|
@keflavich @kalgash82 Yes, a local test doesn't make sense here for the moment because there's no parsing or processing going on. Merging this now ... everyone: if you want to continue working on this, please make a new branch off of |
|
@cdeil Ok sounds good! |
|
And we're live ... :-) |
|
Awesome!! Thanks @cdeil! I'll be working on giving it more functionality in the next days/weeks unless someone has already done something or thinks that will have more time than me. I will let you know if I need some hand with any trouble :-) |
|
Thanks @cdeil! This is a really excellent start! :) |
@abigailStev @kalgash82 @leyder and I will add HEASARC as a service at the Python in astronomy 2015 workshop
http://heasarc.gsfc.nasa.gov/