Skip to content

Conversation

@keflavich
Copy link
Contributor

pyregion is an optional dependency (as I understand), so the test in test_alma_utils.py should handle it accordingly.
Right now it throws an ImportError when test are run on a setup without pyregion. I'm not sure why it isn't picked up by Travis.

======================================================================== ERRORS =========================================================================
_______________________________________________ ERROR collecting astroquery/alma/tests/test_alma_utils.py _______________________________________________
astroquery/alma/tests/test_alma_utils.py:5: in <module>
>   from pyregion.parser_helper import Shape
E   ImportError: No module named pyregion.parser_helper
============================================= 400 passed, 202 skipped, 2 xfailed, 1 error in 30.13 seconds ==============================================

@keflavich
Copy link
Contributor

travis installs pyregion; this is a bug!

@keflavich keflavich added the bug label Jun 4, 2015
@coveralls
Copy link

Coverage Status

Coverage remained the same at 65.33% when pulling fcaefeb on keflavich:issue549 into eb4ca1c on astropy:master.

keflavich added a commit that referenced this pull request Jun 29, 2015
@keflavich keflavich merged commit a12c06f into astropy:master Jun 29, 2015
@keflavich keflavich deleted the issue549 branch June 29, 2015 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants