Adding SPHERE to the instrument list #551
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
There was a problem hiding this comment.
While we at it, I wonder what is the reason to skip the test if the module is not importable (both here in the remote and in the local testing file). Sure, it cannot be imported when keyring is not available, but I think if something else go wrong it may hide undetected because of this try ... except.
Contributor
There was a problem hiding this comment.
Yeah, we should skip tests only if keyring can't be imported.
keflavich
added a commit
that referenced
this pull request
Jun 5, 2015
Adding SPHERE to the instrument list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SPHERE was added to the instrument list, thus the remote test were failing.