Fix SkyView encoding bug for downloading images #594
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adjust the unit test accordingly, to actually download the image and catch this bug.
Contributor
Author
|
Side note: I have changed the '2MASS-K' survey to '2MASS-J', because the former gives me a 404 http error code. Since I didn't see this yesterday, this may be temporary hiccup on the Skyview server. The '2MASS-J' survey works without a problem. |
Contributor
There was a problem hiding this comment.
How big are the files? If they're more than a few MB, could you add a second decorator here, @pytest.mark.bigdata?
Contributor
Author
There was a problem hiding this comment.
The file is relatively small, about 360 KB, since the images get (down)sampled to 300 by 300 pixels by default (and could be reduced further server-side if wanted).
keflavich
added a commit
that referenced
this pull request
Oct 21, 2015
Fix SkyView encoding bug for downloading images
Contributor
|
Excellent, in that case, thanks! Great work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #593
It tentatively fixes the (remote) unit test accordingly, to actually download the image and catch this bug.
There is no change for the local unit test.