Update IRSA dust documentation #597
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The IRSA server changed the returned results, which now includes Schlegel and Finkbeiner next to SFD, and includes a few more filters.
Contributor
|
I gather the examples were out of date? Are the tests still OK? I'm a little confused by this; did something change upstream at IRSA? |
Contributor
Author
|
@keflavich Yes, sorry, the PR comment isn't that clear. But see the (extended) commit message itself: the IRSA server has changed, and the returned data contains a bunch of extra columns and rows. The Travis build & test seems to be happy (though I'm not sure if this example is doc-tested anyway, since the resulting URL is variable). |
Contributor
|
@evertrol no, we don't run the doctests, in part because they require running a remote query, and in part because there are many queries that are not expected to return consistent results. Anyway, thanks, this looks good. |
keflavich
added a commit
that referenced
this pull request
Oct 22, 2015
Update IRSA dust documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that I'm at it, might as well update the docs on the IRSA dust extinction service.