Add back FITS HDU support #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsipocz
reviewed
Nov 26, 2016
Member
bsipocz
left a comment
bsipocz
left a comment
There was a problem hiding this comment.
@astrofrog - This looks good to me.
| @staticmethod | ||
| def read(filename): | ||
| from astropy.io import fits | ||
| return fits.getdata(filename) |
Member
There was a problem hiding this comment.
No need to change this in this PR, but I think it would be nice to be able to compare multi extension fits in the future, or at least be able to loop through the extensions.
Member
|
I wonder whether you can switch off CI for pushes as your appveyor seems to have a significant backlog by running everything twice. |
Member
Author
Should be fixed now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it so that we can actually now compare any kind of data files, and tests can return not just Numpy arrays but anything the format class understands (hence a FITS HDU for the FITS format). Maybe in the long term it would make sense to rename this package
pytest-datadiff. In principle it could be used for any kind of data file, and including tabular or gridded data.cc @bsipocz, since this is needed for your reproject PR. I'll leave this open for a day or so in case you want to review it!