Merged
Conversation
icolwell-as
requested review from
dvangeyn-as,
jilinzhouas,
kmushty-as and
shan-as
jilinzhouas
reviewed
Oct 13, 2021
| { | ||
| public: | ||
| Pacmod3Nl(); | ||
| ~Pacmod3Nl(); |
jilinzhouas
reviewed
Oct 13, 2021
| ~Pacmod3Nl(); | ||
|
|
||
| private: | ||
| void onInit(); |
jilinzhouas
reviewed
Oct 13, 2021
|
|
||
| ros::NodeHandle nh_; | ||
| ros::NodeHandle pnh_; | ||
| std::string veh_type_string = "POLARIS_GEM"; |
jilinzhouas
approved these changes
Oct 19, 2021
dvangeyn-as
approved these changes
Oct 19, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #101 by converting the node to a nodelet. Tested today in lexus, seems to perform the same. The nodelet manager spreads the callback load mainly across 3 threads, which would be same as it worked before (2 async spinner threads and one manually-created can_write thread).