Improve minimal publishing changes#112
Merged
icolwell-as merged 3 commits intoros1_masterfrom Nov 8, 2021
Merged
Conversation
icolwell-as
requested review from
dvangeyn-as,
jilinzhouas,
kmushty-as and
shan-as
dvangeyn-as
approved these changes
Nov 5, 2021
jilinzhouas
approved these changes
Nov 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #103 by always publishing accel, brake, steering, and shift commands right after startup.
This resolves the shifter problem since the driver is now guaranteed to send a disable before an enable on the shifter (this is a requirement in order to enable the system).
Ideally, I think this problem should be solved on the user side (pacmod_game_control), but this works for now and is more consistent with the way the driver used to work. I intend to update pacmod_game_control in the future anyway.