Conversation
cullenstoneAS
requested review from
dvangeyn-as,
icolwell-as,
jilinzhouas and
kmushty-as
| @@ -141,7 +141,9 @@ class Pacmod3Nl : public nodelet::Nodelet | |||
| ros::Publisher all_system_statuses_pub; | |||
| ros::Publisher global_rpt_pub; | |||
| ros::Publisher global_rpt_2_pub; | |||
There was a problem hiding this comment.
All those publisher variables stored into pub_tx_list with std::move should be deleted here.
| @@ -62,7 +64,9 @@ void Pacmod3Nl::onInit() | |||
| vin_rpt_pub = nh_.advertise<pacmod3_msgs::VinRpt>("vin_rpt", 5); | |||
|
|
|||
| pub_tx_list.emplace(GLOBAL_RPT_CANID, std::move(global_rpt_pub)); | |||
There was a problem hiding this comment.
After std::move, these independent publish variables are no longer usable. How about create them as local variables in this function.
There was a problem hiding this comment.
I agree we should improve this, but maybe create a separate issue since it's unrelated to the changes in this PR.
There was a problem hiding this comment.
@icolwell-as sorry I didn't read your comment before I changed it, should I revert the changes for this PR?
There was a problem hiding this comment.
No worries! if the work is done, all the better, just didn't want to hold the PR on something unrelated.
All good! merge at will
4 participants
add missing messages to support Honda SSC
add support for global_rpt_2 for /pacmod/enabled topic