Fix typo "Dissmiss" #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a consistent typo ("Dissmiss") by renaming it to the correct spelling ("Dismiss") across all supported platforms and sample code.
- Renamed functions and methods from
dissmisstodismissin both native (iOS/Android) and managed (C#) code. - Updated Unity sample scene and C# sample methods to match the corrected naming.
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Packages/.../iOS/UNDialogManager.mm & .h | Renamed _dissmissDialog → _dismissDialog and method dissmissDialog: → dismissDialog: |
| Packages/.../Runtime/Internal/IDialog.cs | Renamed interface method Dissmiss → Dismiss |
| Packages/.../Runtime/Internal/DialogMock.cs | Updated Dissmiss → Dismiss and log message |
| Packages/.../Runtime/Internal/DialogIOS.cs | Renamed extern and method calls to Dismiss |
| Packages/.../Runtime/Internal/DialogAndroid.cs | Renamed JNI call and wrapper method to Dismiss |
| Packages/.../Runtime/DialogManager.cs | Updated static Dissmiss → Dismiss and call |
| Packages/.../Android/DialogManager.java | Renamed dissmissDialog → dismissDialog and related static method |
| Assets/NativeDialogSample.unity & Assets/NativeDialogSample.cs | Fixed UI object name and method calls from "AutoDissmiss" → "AutoDismiss" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.