-
Notifications
You must be signed in to change notification settings - Fork 113
Add XLNet Modules #120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add XLNet Modules #120
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally LGTM! Since the current solution is working I don't think we need to change the design, but here's an idea I've just had: it might be possible to make PretrainedBase a "mixin" class, i.e. a class that other classes inherit from for the sole purpose of adding a couple of methods and attributes, and whose constructor is not called. If you're familiar with strongly-typed languages, it's a bit like C++/Rust traits and Java interfaces with default implementations.
But anyway, let's keep it as is for now.
|
The |
|
@ZhitingHu Yes. I am working on it. |
PretrainedBaseand modify the code structure of pre-trained modules.DecoderBase#108