Update simple-s3 to use the new major version of the s3 package #1971
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jderusse
approved these changes
Oct 26, 2025
stof
force-pushed
the
simple_s3_major_version
branch
from
3d02bbe to
606840d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As our
simple-s3extends theasync-aws/s3client, we cannot support multiple versions at the same time (as we inherit BC breaks). Thus, users might rely on the transitive dependency so being strict on the targeted version is also safer.As the not-released changes for
async-aws/s3are targeting a new major version, we need to upgradesimple-s3to also do the same.For the Symfony bundle, I added support for the new major version in the dev dependency, to allow us to use the latest version of the package. This does not matter much in such case (it won't call the client anyway in those tests).