add support for agent metadata CPU and memory fields #106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arielb1
changed the title
arielb1
force-pushed
the
agent-metadata-ctors
branch
from
fbea486 to
e2f39b0
Compare
rcoh
approved these changes
Oct 29, 2025
| #[serde(transparent)] | ||
| pub struct OrderedF64(OrderedFloat<f64>); | ||
|
|
||
| impl OrderedF64 { |
Collaborator
There was a problem hiding this comment.
Another reasonable option could be a string that serde's as a float
arielb1
force-pushed
the
agent-metadata-ctors
branch
2 times, most recently
from
0929049 to
a10b42f
Compare
rcoh
approved these changes
Nov 8, 2025
added 3 commits
November 13, 2025 11:40
we want to allow adding fields to metadata, which requires making them `non_exhaustive`. However, users do create the metadatas, at least for testing. Add constructors to allow that to be done in a back-compat way.
arielb1
force-pushed
the
agent-metadata-ctors
branch
from
a10b42f to
b8cae26
Compare
Collaborator
Author
|
rebased, need re-approval |
rcoh
approved these changes
Nov 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📬 Issue #, if available:
✍️ Description of changes:
🔏 By submitting this pull request