ci: use async-profiler from upstream, fix integration test errors #86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arielb1
force-pushed
the
upstream-async-profiler
branch
from
f571dfe to
ddbc5dc
Compare
Add an explicit allocation since the new async-profiler doesn't capture its own allocations. the original example code didn't call `handle.stop`, which led to a race between shutdown and async-profiler pushing the new JFR. In upstream async-profiler, the race was often lost. Add that, then change the integration test to ignore overly-short samples to avoid it erroring.
arielb1
force-pushed
the
upstream-async-profiler
branch
from
ddbc5dc to
f40e3a1
Compare
arielb1
changed the title
arielb1
changed the title
rcoh
approved these changes
Aug 4, 2025
| - name: Download async-profiler | ||
| shell: bash | ||
| working-directory: tests | ||
| run: wget https://github.com/async-profiler/async-profiler/releases/download/v4.1/async-profiler-4.1-linux-x64.tar.gz -O async-profiler.tar.gz && tar xvf async-profiler.tar.gz && mv -vf async-profiler-*/lib/libasyncProfiler.so . |
There was a problem hiding this comment.
do we need some kind of recurring task to keep this up to date? Or is there a way to get the URL for the latest release? Alternatively I guess we could vend this version somehow?
I just want to avoid the case where we're testing on a different version than our customers are using, especially since pollcatch is using those unstable APIs
| stack_depth: usize, | ||
| }, | ||
| /// Print the total duration (in seconds) of the JFR recording. Used in the integration tests. | ||
| Duration { |
There was a problem hiding this comment.
what if we made this show (and currently it only prints duration) but it could be a generally useful place to put metadata that people can use?
There was a problem hiding this comment.
this is intended for use by a very specific shell script
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ci: use async-profiler from upstream
Add an explicit allocation since the new async-profiler doesn't capture its own allocations.
the original example code didn't call
handle.stop, which led to a race between shutdown and async-profiler pushing the new JFR. In upstream async-profiler, the race was often lost. Add that, then change the integration test to ignore overly-short samples to avoid it erroring.Fixes #84.
📬 Issue #, if available:
✍️ Description of changes:
🔏 By submitting this pull request