Skip to content

Conversation

arielb1
Copy link
Collaborator

@arielb1 arielb1 commented Aug 10, 2025

📬 Issue #, if available:

✍️ Description of changes:

🔏 By submitting this pull request

  • I confirm that I've made a best effort attempt to update all relevant documentation.
  • I confirm that my contribution is made under the terms of the Apache 2.0 license.

@arielb1 arielb1 requested review from jlizen and rcoh and removed request for rcoh August 10, 2025 14:27
Copy link
Collaborator

@rcoh rcoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, seems like for a few of these it's probably easy to add diagnostic logging? Open an issue to track?

@arielb1
Copy link
Collaborator Author

arielb1 commented Aug 10, 2025

Lgtm, seems like for a few of these it's probably easy to add diagnostic logging? Open an issue to track?

diagnostic logging on the async-profiler side would be great

I am not sure we should have longform error messages in decoder.rs

@arielb1 arielb1 merged commit ad1946b into async-profiler:main Aug 10, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants