-
Notifications
You must be signed in to change notification settings - Fork 27
Upgrade to Maven Wrapper 3.2.0 #134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
JohnNiang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jchrys , I suggest using mvn wrapper:wrapper -Dmaven=3.2.0 to upgrade Maven Wrapper. Please refer to https://maven.apache.org/wrapper/#using-a-different-version-of-maven.
git status
HEAD detached at upstream/trunk
Changes not staged for commit:
(use "git add <file>..." to update what will be committed)
(use "git restore <file>..." to discard changes in working directory)
modified: .mvn/wrapper/maven-wrapper.properties
modified: mvnw
modified: mvnw.cmd|
@JohnNiang Thanks a lot! |
|
I just tried to execute |
Please refer to https://github.com/asyncer-io/r2dbc-mysql/compare/trunk...JohnNiang:chore/upgrade-maven-wrapper?expand=1 |
|
I see. Thanks a lot. It seems that we've been used non-official version(or EOL). Would you mind if I create PR using yours? |
Of course! Feel free to use the information and resources I provided to create the PR. If you have any questions or need further assistance during the process, feel free to ask. |
Motivation: Ensure up-to-date with Maven Wrapper Modification: Use Maven Wrapper 3.2.0 Result: Up-to-date
|
:D I just applied it. @JohnNiang PTAL |
JohnNiang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Motivation: Ensure up-to-date with Maven Wrapper Modification: Use Maven Wrapper 3.2.0 Result: Up-to-date Co-authored-by: John Niang <johnniang@fastmail.com>
Motivation:
Ensure up-to-date with Maven Wrapper
Modification:
Use Maven Wrapper 3.2.0
Result:
Up-to-date