Skip to content

Conversation

@jchrys
Copy link
Collaborator

@jchrys jchrys commented Jul 16, 2023

Motivation:
Ensure up-to-date with Maven Wrapper

Modification:
Use Maven Wrapper 3.2.0

Result:
Up-to-date

Copy link
Contributor

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jchrys , I suggest using mvn wrapper:wrapper -Dmaven=3.2.0 to upgrade Maven Wrapper. Please refer to https://maven.apache.org/wrapper/#using-a-different-version-of-maven.

git status
HEAD detached at upstream/trunk
Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
	modified:   .mvn/wrapper/maven-wrapper.properties
	modified:   mvnw
	modified:   mvnw.cmd

@jchrys
Copy link
Collaborator Author

jchrys commented Jul 16, 2023

@JohnNiang Thanks a lot!

@jchrys
Copy link
Collaborator Author

jchrys commented Jul 16, 2023

I just tried to execute mvn wrapper:wrapper -Dmaven=3.9.3. but it seems OK. I couldn't find diffs.

@JohnNiang
Copy link
Contributor

I just tried to execute mvn wrapper:wrapper -Dmaven=3.9.3. but it seems OK. I couldn't find diffs.

Please refer to https://github.com/asyncer-io/r2dbc-mysql/compare/trunk...JohnNiang:chore/upgrade-maven-wrapper?expand=1

@jchrys
Copy link
Collaborator Author

jchrys commented Jul 16, 2023

I see. Thanks a lot. It seems that we've been used non-official version(or EOL). Would you mind if I create PR using yours?

@JohnNiang
Copy link
Contributor

I see. Thanks a lot. It seems that we've been used non-official version(or EOL). Would you mind if I create PR using yours?

Of course! Feel free to use the information and resources I provided to create the PR. If you have any questions or need further assistance during the process, feel free to ask.

Motivation:
Ensure up-to-date with Maven Wrapper

Modification:
Use Maven Wrapper 3.2.0

Result:
Up-to-date
@jchrys
Copy link
Collaborator Author

jchrys commented Jul 18, 2023

:D I just applied it. @JohnNiang PTAL

Copy link
Contributor

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jchrys jchrys merged commit ebf58ee into trunk Jul 18, 2023
@jchrys jchrys deleted the 1x-update-mvnw branch July 18, 2023 15:38
@jchrys jchrys added this to the 1.0.3 milestone Sep 18, 2023
jchrys added a commit that referenced this pull request Sep 18, 2023
Motivation:
Ensure up-to-date with Maven Wrapper

Modification:
Use Maven Wrapper 3.2.0

Result:
Up-to-date

Co-authored-by: John Niang <johnniang@fastmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants