Implement ByteArrayInputstream codec #316
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongKos
force-pushed
the
feature-inputstream-codec
branch
from
1602538 to
ff1c9da
Compare
dongKos
force-pushed
the
feature-inputstream-codec
branch
from
ff1c9da to
f5fe451
Compare
|
|
jchrys
force-pushed
the
feature-inputstream-codec
branch
from
f5fe451 to
7c3913b
Compare
jchrys
reviewed
May 20, 2025
r2dbc-mysql/src/main/java/io/asyncer/r2dbc/mysql/codec/ByteArrayInputStreamCodec.java
Outdated
Show resolved
Hide resolved
r2dbc-mysql/src/main/java/io/asyncer/r2dbc/mysql/codec/ByteArrayInputStreamCodec.java
Outdated
Show resolved
Hide resolved
r2dbc-mysql/src/main/java/io/asyncer/r2dbc/mysql/codec/ByteArrayInputStreamCodec.java
Outdated
Show resolved
Hide resolved
r2dbc-mysql/src/test/java/io/asyncer/r2dbc/mysql/codec/ByteArrayInputStreamCodecTest.java
Outdated
Show resolved
Hide resolved
Author
|
@jchrys |
dongKos
changed the title
dongKos
force-pushed
the
feature-inputstream-codec
branch
3 times, most recently
from
4bc4e09 to
e2eefdd
Compare
dongKos
force-pushed
the
feature-inputstream-codec
branch
from
e2eefdd to
4abbb37
Compare
jchrys
requested changes
Jun 26, 2025
Collaborator
jchrys
left a comment
jchrys
left a comment
There was a problem hiding this comment.
Overall lgtm,
just a nit
r2dbc-mysql/src/main/java/io/asyncer/r2dbc/mysql/codec/ByteArrayInputStreamCodec.java
Show resolved
Hide resolved
Collaborator
|
Could you rebase and squash this into a single commit and add a Signed-off-by line? Thanks! |
dongKos
force-pushed
the
feature-inputstream-codec
branch
from
4abbb37 to
5926f76
Compare
- Fixed canEncode, doCanDecode conditions - Update Copyright Year - Add tests for ByteArrayInputStreamCodec - Implement ByteArrayInputStreamCodec Signed-off-by: dongKos <dhkim931101@naver.com> Signed-off-by: 김동환 <dhkim931101@naver.com>
dongKos
force-pushed
the
feature-inputstream-codec
branch
from
5926f76 to
338f822
Compare
jchrys
approved these changes
Jun 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jchrys #314
Motivation:
Implement ByteArrayInputStreamCodec to support InputStream
Modification:
Add ByteArrayInputStreamCodec, Add Tests
Result:
Can support InpuStream for Parameter Binding