refactor: extract process.kill to stopServer method

[felixmosh]

I need this method for a rsbuild adapter...
When rsbuild restarts the dev-server, this plugin doesn't closes the running server....

[atassis]

1. There are both code clean and logical changes in single commit, makes it harder to review what is done.
2. I'ld suggest to make some sense in ordering methods, for example, apply method has moved to top and looks like a new method, while _stopServer is placed on its place. I think, it would be better to keep private and public methods separated, if order is changed at all.

[felixmosh]

1. there is no logical changes at all, I've just extracted a repeated code into a stopServer method.
2. regarding sorting the methods, i will revert the change :]

[felixmosh]

How is it now?

[atassis]

LGTM now

[atassis]

I am preparing to some medical interventions, will publish a new version in between preparations (today)

[felixmosh]

Good luck :]

[atassis]

v0.2.1 deployed
Check that everyone is ok for you, please.
And thanks!

[felixmosh]

It works as expected,
Will you recieve a PR that makes the start / stop / restart methods public.
(I need them for the rsbuild adapter, to support rsbuild reload build feature).

function runScriptPlugin(): RsbuildPlugin {
  return {
    name: 'run-script-webpack-plugin',
    setup: (api) => {
      let runServerPlugin;

      api.modifyRspackConfig((config, { isDev }) => {
        if (!isDev) {
          return;
        }

        runServerPlugin = new RunScriptWebpackPlugin({
          name: 'server.js',
          autoRestart: false,
          restartable: false,
          signal: false,
          nodeArgs: process.env.INSPECT ? ['--inspect'] : [],
        });

        config.plugins.push(runServerPlugin);
      });

      api.onCloseDevServer(() => {
        runServerPlugin?._stopServer({ force: true }); // needed since signal must be false for HMR
      });
    },
  };
}

[atassis]

I won't be available to do anything this week, but you are free to create a PR, I'll check it later. Doesn't look it ld break anything, so I might approve this change