Add the possiblity to change the signature method #1160
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RSA_SHA512 was hardcoded in the REST Client for OAuth1. It is now possible to change the 'Signature Method' in the 'oauth_dict' with the key 'signature_method' to another signature. The default value is kept as 'SIGNATURE_RSA' if no value for the mentioned key is provided.
RSA_SHA512 was hardcoded in the REST Client for OAuth1. It is now possible to change the 'Signature Method' in the 'oauth_dict' with the key 'signature_method' to another signature. The default value is kept as 'SIGNATURE_RSA' if no value for the mentioned key is provided.
Codecov ReportPatch and project coverage have no change.
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## master #1160 +/- ##
=======================================
Coverage 34.07% 34.07%
=======================================
Files 40 40
Lines 7616 7616
Branches 1056 1056
=======================================
Hits 2595 2595
Misses 4911 4911
Partials 110 110
☔ View full report in Codecov by Sentry. |
|
@h-braun Thank you for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RSA_SHA512 was hardcoded in the REST Client for OAuth1. It is now possible to change the 'Signature Method' in the 'oauth_dict' with the key 'signature_method' to another signature. The default value is kept as 'SIGNATURE_RSA' if no value for the mentioned key is provided.