Skip to content

Conversation

@isaac-philip
Copy link
Contributor

To provide option to export CURRENT fields also in addition to existing ALL fields

Default : ALL fields (existing and non-breaking change)

  • Functionality addition in atlassian/jira
  • Example added
  • Constants file added to have project related constants
  • Docs example added

Closes #602

To provide option to export CURRENT fields also in addition to existing ALL fields

Default : ALL fields (existing and non-breaking change)

- Functionality addition in `atlassian/jira`
- Example added
- Constants file added to have project related constants
- Docs example added

Closes atlassian-api#602
@gonchik
Copy link
Member

gonchik commented Oct 11, 2020

Hi!
First of all, thank you for your pull request.
One thing, what is the purpose to make contans.py file ?
Is it possible wrap into more generic way?

@isaac-philip
Copy link
Contributor Author

Hello @gonchik
so let me explain purpose of constants.py

aiming to have DRY with the urls and so on.
any constants can go here to be referenced in other files.
good practice to refer URI/URL(s) as constant rather than declaring at usage.

if i have same URI duplicated in the jira.py then thats against DRY.
this will help to reduce redundancy right.

just beginning to go towards linting and other checks of quality on code.
beginning to prepare towards it

let me know your views. 😊

@isaac-philip
Copy link
Contributor Author

Hello @gonchik ,

any changes required to close this?

@gonchik
Copy link
Member

gonchik commented Oct 16, 2020

Hi @isaac-philip ,
can we postpone for now the constants.py ?
Because it's unclear in the future how to manage it for all others rest end point, I mean for confluence, bamboo etc,

@gonchik gonchik merged commit a7689eb into atlassian-api:master Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[JIRA] Issues export to CSV - CURRENT FIELDS option

2 participants