Skip to content

Fixed #59 #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 12, 2014
Merged

Fixed #59 #60

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
95c421c
unsubscribe scrollView events
fundon Apr 10, 2014
1ff608d
update comments
fundon Apr 11, 2014
5d041d4
update comments
fundon Apr 11, 2014
1b3d924
remove unnecessary minimapScroll variable
fundon Apr 12, 2014
213f220
force to check scrollView and editor variables, #59
fundon Apr 12, 2014
1bed024
Release 0.9.1
fundon Apr 12, 2014
af9f3c2
update history
fundon Apr 12, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions History.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
0.9.1 / 2014-04-13
==================

* fix minimap doesn't update on active view changes when auto-toggle is true, #59

0.9.0 / 2014-04-11
==================

Expand Down
5 changes: 3 additions & 2 deletions lib/minimap-indicator.coffee
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,13 @@
# | |----------> Minimap Wrapper
# | | .
# | | .
# #########------> Minimap Indicator (Minimap visible area)
# =========------> Minimap Indicator
# | | .
# --------- .
# . .
# .............
#

#
# Basic Rectangle
#
Expand Down Expand Up @@ -120,4 +122,3 @@ class Indicator extends Rectangle

computeFromCenterY: (cy) ->
@setCenterY(cy) - @scroller.y

4 changes: 2 additions & 2 deletions lib/minimap-view.coffee
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ class MinimapView extends View
@scaleY = @scaleX * 0.8
@minimapScale = @scale(@scaleX, @scaleY)
@miniScrollView = @miniEditorView.scrollView
@minimapScroll = 0
@transform @miniWrapper[0], @minimapScale
# dragging's status
@isPressed = false
Expand Down Expand Up @@ -93,7 +92,8 @@ class MinimapView extends View
@subscribeToEditor()

unsubscribeFromEditor: ->
@unsubscribe @editor, '.minimap'
@unsubscribe @editor, '.minimap' if @editor?
@unsubscribe @scrollView, '.minimap' if @scrollView?

subscribeToEditor: ->
@subscribe @editor, 'screen-lines-changed.minimap', @updateMinimapEditorView
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "minimap",
"main": "./lib/minimap",
"version": "0.9.0",
"version": "0.9.1",
"private": true,
"description": "A preview of the full source code.",
"author": "Fangdun Cai <cfddream@gmail.com>",
Expand Down