-
Notifications
You must be signed in to change notification settings - Fork 127
fix: prevent error when minimap squashed #713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: prevent error when minimap squashed #713
Conversation
4521c9d to
1c25474
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these canvas.width and offscreenCanvas.width values calculated on the fly or they are cached/constant?
|
I believe they are calculated |
|
Could you benchmark the call to them? let t1 = window.performance.now()
// call to these
console.log(window.performance.now() - t1) |
|
I got |
|
Sounds good. I will test this tomorrow if I find some time. |
5909ffb to
1ec8f12
Compare
|
🎉 This PR is included in version 4.31.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |

Fix error when the middle pane is 0 width
Fixes atom-community#15
Fixes #702
Originally posted at atom-community#13 (comment) by @UziTech