Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Conversation

@anaisbetts
Copy link
Contributor

Atom build servers on Windows only have VS2010 installed. Support using either one, but prefer VS2012 if both are present.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would fs.existsSync work here instead? Seems similar.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On Windows, it is possible (though unlikely in this case) that you could determine that a file exists but you can't actually read it (because of busted permissions, your computer hates you, etc).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, but I thought node's fs.existsSync is implemented this same way: https://github.com/joyent/node/blob/master/lib/fs.js#L161-L169

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Legit. Replacing

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need parens around isWin32

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We usually sport a little if vsArgs? instead of direct compares to null

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL a cool CoffeeScript hack

@zcbenz
Copy link
Contributor

zcbenz commented Oct 22, 2013

@paulcbetts this PR seems nearly completed, is there any blocking problem?

@anaisbetts
Copy link
Contributor Author

@zcbenz Think I just spaced on it. I'll get it checked in today.

anaisbetts pushed a commit that referenced this pull request Oct 22, 2013
Detect Visual Studio versions on the fly
@anaisbetts anaisbetts merged commit de66a60 into master Oct 22, 2013
@kevinsawicki kevinsawicki deleted the detect-vs2010-vs2012 branch October 22, 2013 19:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants