Skip to content

Conversation

@arsher
Copy link

@arsher arsher commented Nov 5, 2015

I've been looking into how to create detachable webviews, or better said something that can transfer the content into another webview instance. It might be a bit hacky currently, I'm pretty sure it's not prod quality yet, but I wanted something working to start the conversation.

I've seen #1682 which led me to the conclusion that I'm not alone with the desire to have something like this, hence this PR.

@deepak1556
Copy link
Member

Nice! Just a few thoughts, could add WebViewManager::TransferGuest(sourceGuestInstanceId, targetElementInstanceId, targetGuestInstanceId) and let guest-view-manger use it to change mapping of guestinstanceid to embedder. Also ipc operations in web-view can be moved to guest-view-internaland ones' in web-view-ref can be handled by guest-view-manager. Not sure about the need for WebViewRef class.

@anaisbetts
Copy link
Contributor

@arsher This is awesome, good start!

@zcbenz
Copy link
Contributor

zcbenz commented Nov 9, 2015

Can you add some documents for it?

@arsher
Copy link
Author

arsher commented Nov 12, 2015

Sure thing, I'm sorry I had about zero amount of free time, I'll try to do some docs and responses for the comments during the weekend.

@alexandernst
Copy link

Is this the same thing as atom/atom#9334 ?

@zcbenz
Copy link
Contributor

zcbenz commented Dec 8, 2015

I'm closing this since there were no updates and the PR is outdated, but I'll be glad to reopen once there are new updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants