Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Commit 52e9782

Browse files
committed
add an alternative to header 🤔
1 parent 6682d2e commit 52e9782

File tree

1 file changed

+3
-5
lines changed

1 file changed

+3
-5
lines changed

docs/feature-requests/006-pull-request-reviewer-flow.md

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -23,12 +23,10 @@ This tab shows all review summaries and review comments, including the ones that
2323
|<img width="380" alt="old header" src="https://user-images.githubusercontent.com/6842965/56446925-7f027600-62d3-11e9-8635-e17b946f3b1b.png">|<img width="380" alt="new header" src="https://user-images.githubusercontent.com/6842965/56446924-7f027600-62d3-11e9-98f5-0ea1e2826343.png">|<img width="380" alt="new header" src="https://user-images.githubusercontent.com/6842965/56447078-4911c180-62d4-11e9-8543-4935ba587b38.png">|
2424

2525
- When there is no pending review, button reads "Start a review", clicking on which will take you to the Pending Review tab in its empty state.
26-
- When there is already a pending review, the button reads "Resume review (2)". The number indicates the number of comments currently in the pending review. When adding more pending comments _within the All Reviews tab_, there should be some emphasis on the number changing -- akin to the button on dotcom. Clicking on this button takes user to the Pending Review tab.
26+
- When there is already a pending review, the button reads "Resume review (2)". The number is a counter of comments currently in the pending review. When adding more pending comments _within the All Reviews tab_ (more on that flow below), there should be some emphasis on the counter changing -- akin to the button on dotcom. Clicking on this button takes user to the Pending Review tab.
2727

28-
##### On scaling down the "Checkout" button to just an icon
29-
- rationale
30-
- caveats
31-
- mitigation
28+
##### Alternative: footer
29+
An alternative would be to add a footer bar at the bottom and place the add review button there. The caveat is that it might not be as noticeable as the header, and "start a new review" is an arguably more important action than "checkout".
3230

3331
#### Responding to a comment thread
3432
start a new review button

0 commit comments

Comments
 (0)