You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Copy file name to clipboardExpand all lines: docs/feature-requests/006-pull-request-reviewer-flow.md
+39-6Lines changed: 39 additions & 6 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -14,18 +14,51 @@ Provide code review to an existing pull request within Atom.
14
14
15
15
## :checkered_flag: Motivation
16
16
17
-
We already have a workflow built out for the receiving end of pull request reviews; it only makes sense to also build out a workflow for users to author pull request reviews.
17
+
We already have an innovative review-comments-in-dock (RCID) workflow built out for the receiving end of pull request reviews. In order to complete the full experience of code review within Atom, we should also build out a workflow for users to author pull request reviews.
18
18
19
19
## 🤯 Explanation
20
20
21
+
### "All Reviews" tab
22
+
This tab shows all review summaries and review comments, including the ones that are part of a _pending review_ that has not been submitted yet.
23
+
24
+
#### Header
25
+
- When there is no pending review, button reads "Start a pending review", clicking on which will take you to the Pending Review tab in its empty state.
26
+
- When there is already a pending review, the button reads "Resume review (2)". The number indicates the number of comments currently in the pending review. When adding more pending comments _within the All Reviews tab_, there should be some emphasis on the number changing -- akin to the button on dotcom. Clicking on this button takes user to the Pending Review tab.
27
+
28
+
29
+
- rationale for scaling down the "Checkout" button
30
+
- caveats of doing so
31
+
- mitigation
32
+
33
+
#### Responding to a comment thread
34
+
start a new review button
35
+
36
+
#### Pending comments
37
+
38
+
Pending comments within the All Reviews tab are styled differently from the already published comments. Pending comments contain a way to direct user to the Pending Review tab.
39
+
40
+
41
+
42
+
43
+
### "Pending Review" tab
44
+
This tab shows a *subset* of all reviews -- only the summary and comments of a pending review. Since a user is only allowed to have one pending review at a time, there should also only be one active Pending Review tab.
45
+
46
+
#### Header
47
+
The header looks very similar to the one of All Reviews tab, with the exception that the primary button now reads "See all reviews", and will send users back to the All Reviews tab.
48
+
49
+
50
+
#### Summary section
51
+
52
+
- sticky
53
+
- drop down to select review type
54
+
- button to submit review
55
+
56
+
#### Comments section
57
+
58
+
- empty state
21
59
22
60
23
-
Explain the proposal as if it was already implemented in the GitHub package and you were describing it to an Atom user. That generally means:
24
61
25
-
- Introducing new named concepts.
26
-
- Explaining the feature largely in terms of examples.
27
-
- Explaining any changes to existing workflows.
28
-
- Design mock-ups or diagrams depicting any new UI that will be introduced.
0 commit comments