context menu "open file"

[lloiser]

Prerequisites

• Have you tried to reproduce the problem in Safe Mode? Yes, also happens there
• Have you followed all applicable steps in the debugging guide? Yes
• Have you checked the FAQs on the message board for common solutions? Yes
• Have you checked that your issue isn't already filed? Yes

Description

The "Open file" context menu on each file in the git tab is not really consistent.

Steps to Reproduce

Checkout any repo. Delete a file, modify a file and add a file.

Unfortunately it happens randomly when opening the context menu. Here is a gif I captured:

As you can see the "Open file" entry appears and disappears randomly for files...

Expected behavior:
Actual behavior:

Files that have been removed sometimes get "Open file" whereas they shouldn't, because there is no file anymore.
Files that have been added/modified sometimes get no "Open file" even though they should have it.

Reproduces how often:

Pretty often but it's almost impossible to reproduce a specific way that 100% fails all the time...

Versions

$ atom -v
Atom    : 1.25.0
Electron: 1.7.11
Chrome  : 58.0.3029.110
Node    : 7.9.0

$ apm -v
apm  1.19.0
npm  3.10.10
node 6.9.5 x64
atom 1.25.0
python 2.7.10
git 2.10.1

github@0.10.3

[Ben3eeE]

I can reproduce this if I right click in the lowermost/uppermost part of a filename that is not selected. Closer to the middle seems to always show the option for me.

[lloiser]

Just a short update:
The "Stage" and "Discard Changes" now consistently are not shown if nothing is selected in the git tab.

$ atom -v
Atom    : 1.30.0
Electron: 2.0.5
Chrome  : 61.0.3163.100
Node    : 8.9.3

$ apm list
...
├── github@0.18.3
...