Uncaught TypeError: Cannot read property 'scrollIntoViewIfNeeded' of undefined

[sgsvnk]

Edit by @rsese to add repro steps

From @Ben3eeE /cc #935 (comment):

1. Open Atom in atom/atom
2. Create a new file called foo in the root of the repository
3. Open .gitignore, delete all contents and save the file

Atom 1.26.0-beta1, Windows 10 and macOS 10.12.6.

---

Atom: 1.18.0 x64
Electron: 1.3.15
OS: Mac OS X 10.12.5
Thrown From: github package 0.3.3

Stack Trace

Uncaught TypeError: Cannot read property 'scrollIntoViewIfNeeded' of undefined

At /Users/gsooris/Documents/Installations/Atom.app/Contents/Resources/app/node_modules/github/lib/views/staging-view.js:426

TypeError: Cannot read property 'scrollIntoViewIfNeeded' of undefined
    at StagingView.writeAfterUpdate (/Users/gsooris/Documents/Installations/Atom.app/Contents/Resources/app/node_modules/github/lib/views/staging-view.js:426:50)
    at updateSync (/Users/gsooris/Documents/Installations/Atom.app/Contents/Resources/app/node_modules/github/node_modules/etch/lib/component-helpers.js:126:21)
    at Object.update (/Users/gsooris/Documents/Installations/Atom.app/Contents/Resources/app/node_modules/github/node_modules/etch/lib/component-helpers.js:62:11)
    at StagingView.selectNext (/Users/gsooris/Documents/Installations/Atom.app/Contents/Resources/app/node_modules/github/lib/views/staging-view.js:343:33)
    at HTMLDivElement.core:move-down (/Users/gsooris/Documents/Installations/Atom.app/Contents/Resources/app/node_modules/github/lib/views/staging-view.js:166:42)
    at CommandRegistry.module.exports.CommandRegistry.handleCommandEvent (/Users/gsooris/Documents/Installations/Atom.app/Contents/Resources/app/src/command-registry.js:265:35)
    at /Users/gsooris/Documents/Installations/Atom.app/Contents/Resources/app/src/command-registry.js:3:65
    at KeymapManager.module.exports.KeymapManager.dispatchCommandEvent (/Users/gsooris/Documents/Installations/Atom.app/Contents/Resources/app/node_modules/atom-keymap/lib/keymap-manager.js:610:22)
    at KeymapManager.module.exports.KeymapManager.handleKeyboardEvent (/Users/gsooris/Documents/Installations/Atom.app/Contents/Resources/app/node_modules/atom-keymap/lib/keymap-manager.js:401:28)
    at WindowEventHandler.module.exports.WindowEventHandler.handleDocumentKeyEvent (/Users/gsooris/Documents/Installations/Atom.app/Contents/Resources/app/src/window-event-handler.js:100:42)
    at HTMLDocument.<anonymous> (/Users/gsooris/Documents/Installations/Atom.app/Contents/Resources/app/src/window-event-handler.js:3:65)

Commands

     -2:13.3.0 tree-view:show (atom-workspace.workspace.scrollbars-visible-when-scrolling)
     -1:40.6.0 core:select-all (div.github-StagingView.unstaged-changes-focused)
  3x -0:39.2.0 tree-view:toggle-focus (atom-pane.pane)
     -0:35.5.0 key-binding-resolver:toggle (atom-pane.pane)
  2x -0:35 editor:toggle-line-comments (atom-pane.pane)
     -0:32.7.0 key-binding-resolver:toggle (atom-pane.pane)
     -0:31.7.0 editor:toggle-line-comments (atom-pane.pane)
  2x -0:31.1.0 key-binding-resolver:toggle (atom-pane.pane)
  2x -0:29.5.0 editor:toggle-line-comments (atom-pane.pane)
  2x -0:23.1.0 tree-view:toggle (atom-pane.pane)
     -0:20.8.0 tree-view:open-selected-entry-in-pane-9 (div.tool-panel.tree-view)
  5x -0:09.0 github:toggle-git-tab-focus (atom-pane.pane)
     -0:05.5.0 core:move-down (div.github-StagingView.unstaged-changes-focused)
     -0:05.2.0 core:move-up (div.github-StagingView.unstaged-changes-focused)

Non-Core Packages

angularjs 0.4.0 
atom-beautify 0.29.26 
atom-typescript 11.0.3 
auto-update-packages 1.0.1 
autoclose-html 0.23.0 
autocomplete-modules 1.6.10 
clipboard-history 0.6.6 
clipboard-plus 0.5.1 
docblockr 0.10.3 
emmet 2.4.3 
expand-region 0.3.0 
file-icons 2.1.7 
hyperclick 0.0.40 
intellij-idea-keymap 0.2.3 
javascript-snippets 1.2.1 
js-hyperclick 1.11.0 
js-refactor 0.7.5 
language-babel 2.65.2 
last-cursor-position 0.9.2 
multi-cursor 2.1.5 
next-line-comment 0.2.1 
pigments 0.39.1 
react 0.16.2 
refactor 0.11.4 
Stylus 3.1.1 

[rsese]

Thanks for the report! Can you confirm a few things for us?

• what were you doing at the time of the error?
• is the error is reproducible?
• if reproducible, do you see the error in safe mode (atom --safe)?

[sgsvnk]

Been using the new update for a while but not able to reproduce this. I'll update the the issue when I have more information.

[rsese]

Sounds good and thanks for letting us know that you haven't seen the error since updating ✌️

[broccolini]

• Steps to reproduce: Select all (command+A) unstaged changes, which are a lot of files, including a jekyll _site folder and node modules (guessing this is a slightly unusual scenario).
• I checked and I can reproduce: I updated the github package and other packages, restarted twice, and when I select all stages changes I get this error again. I also got this other error after restarting Atom too

Atom: 1.19.5 x64
Electron: 1.6.9
OS: Mac OS X 10.11.6
Thrown From: github package 0.5.0

Stack Trace

Uncaught TypeError: Cannot read property 'scrollIntoViewIfNeeded' of undefined

At /Users/broccolini/.atom/packages/github/lib/views/staging-view.js:352

TypeError: Cannot read property 'scrollIntoViewIfNeeded' of undefined
    at StagingView.writeAfterUpdate (/packages/github/staging-view.js:352:21)
    at updateSync (/packages/github/node_modules/etch/lib/component-helpers.js:134:15)
    at /packages/github/node_modules/etch/lib/component-helpers.js:72:7
    at DefaultScheduler.performUpdates (/packages/github/node_modules/etch/lib/default-scheduler.js:48:34)

Commands

     -1:05.3.0 github:toggle-git-tab (atom-pane.pane)
     -0:23 core:select-all (div.github-StagingView.unstaged-changes-focused)

Non-Core Packages

busy-signal 1.4.3 
firewatch-syntax 1.1.1 
github-atom-light-syntax 0.3.2 
intentions 1.1.5 
linter 2.2.0 
linter-stylelint 4.0.2 
linter-ui-default 1.6.8 
wakatime 7.0.3 

[rsese]

Halloooo @broccolini 👋

Steps to reproduce: Select all (command+A) unstaged changes, which are a lot of files, including a jekyll _site folder and node modules (guessing this is a slightly unusual scenario).

Interesting, so right after doing a select all of unstaged changes when there's a large number of changes, you'll get this error consistently? Do you know about about how many unstaged files there are? Lastly, do you get this error in safe mode too (atom --safe)?

[DirtyF]

[Enter steps to reproduce:]

1. Browse new files in Unstaged changes panel
2. Press arrow down key on the last file

Atom: 1.20.1 x64
Electron: 1.6.9
OS: Mac OS X 10.12.6
Thrown From: github package 0.4.0

Stack Trace

Uncaught TypeError: Cannot read property 'scrollIntoViewIfNeeded' of undefined

At /Applications/Atom.app/Contents/Resources/app/node_modules/github/lib/views/staging-view.js:488

TypeError: Cannot read property 'scrollIntoViewIfNeeded' of undefined
    at StagingView.writeAfterUpdate (/Applications/Atom.app/Contents/Resources/app/node_modules/github/lib/views/staging-view.js:488:50)
    at updateSync (/Applications/Atom.app/Contents/Resources/app/node_modules/github/node_modules/etch/lib/component-helpers.js:126:21)
    at /Applications/Atom.app/Contents/Resources/app/node_modules/github/node_modules/etch/lib/component-helpers.js:72:13
    at DefaultScheduler.performUpdates (/Applications/Atom.app/Contents/Resources/app/node_modules/github/node_modules/etch/lib/default-scheduler.js:48:40)

Commands

     -5:56 tree-view:show (atom-workspace.workspace.scrollbars-visible-when-scrolling)
     -5:10.4.0 find-and-replace:show (input.hidden-input)
     -5:08.6.0 core:confirm (input.hidden-input)
     -4:36.4.0 core:backspace (input.hidden-input)
     -4:36 core:paste (input.hidden-input)
 13x -4:35.2.0 core:move-left (input.hidden-input)
     -4:33.1.0 core:move-right (input.hidden-input)
     -4:32.7.0 core:backspace (input.hidden-input)
     -4:01.3.0 settings-view:open (input.hidden-input)
     -3:51.1.0 core:backspace (input.hidden-input)
     -2:54.9.0 core:save (input.hidden-input)
     -2:53.6.0 core:close (input.hidden-input)
     -2:31.1.0 core:confirm (span.github-FilePatchListView-path)
 76x -2:24.6.0 core:move-down (div.github-StagingView.unstaged-changes-focused)

Non-Core Packages

asciidoc-preview 2.10.2 
atom-beautify 0.30.5 
atom-ctags 5.1.0 
atom-liquid-snippets 0.3.0 
atom-runner 2.7.1 
Atom-Syntax-highlighting-for-Sass 0.5.0 
atom-ternjs 0.18.3 
auto-update-packages 1.0.1 
autoclose-html 0.23.0 
autocomplete-emojis 2.5.0 
blame 0.12.0 
busy-signal 1.4.3 
caniuse 0.9.2 
cobalt2-syntax 0.5.1 
cucumber 0.6.0 
editorconfig 2.2.2 
elm-format 3.0.0 
emmet 2.4.3 
file-icons 2.1.12 
fonts 3.0.3 
gist 1.0.0 
git-plus 7.9.3 
guard-rspec 0.4.0 
hard-wrap 1.1.0 
highlight-selected 0.13.1 
inline-markdown-images 1.0.0 
intentions 1.1.5 
jekyll 2.1.0 
language-apache 1.7.0 
language-asciidoc 1.10.0 
language-elm 1.5.0 
language-hugo 0.3.1 
language-liquid 0.6.0 
language-markdown 0.25.1 
language-slim 0.6.0 
lebab 0.10.0 
linter 2.2.0 
linter-alex 4.0.0 
linter-csslint 2.0.0 
linter-htmlhint 1.3.3 
linter-js-yaml 1.2.7 
linter-json-lint 0.1.2 
linter-markdown 5.2.0 
linter-markdownlint 1.0.1 
linter-remark 5.0.0 
linter-rubocop 2.1.1 
linter-slim 1.0.0 
linter-stylelint 4.0.2 
linter-ui-default 1.6.10 
linter-write-good 0.9.0 
linter-xo 0.23.1 
markdown-lists 0.0.2 
markdown-writer 2.7.2 
mdn-doc 0.3.0 
merge-conflicts 1.4.5 
prettier-atom 0.40.0 
pretty-json 1.6.4 
react 0.16.2 
rubocop-auto-correct 1.5.1 
sort-lines 0.15.0 
standard-formatter 2.8.0 
stylefmt 5.0.1 
terminal-plus 0.14.5 
tidy-markdown 3.0.1 
travis-ci-status 1.3.1 
webbox-color 0.5.9 
wordcount 2.10.4 
yaml-sortkey 0.1.0 
Zen 0.18.0 

[rsese]

Browse new files in Unstaged changes panel
Press arrow down on last file

Thanks @DirtyF - I wasn't able to reproduce building from master (1.22.0-dev-1f25cda7c), can you reproduce consistently? And can you reproduce in any project like a simple 1 file test project or just one particular project?

[DirtyF]

I could reproduce it today with atom-beta (1.21.0). It seems related to the node_modules folder (adding the folder to .gitignore can even make the editor crash).

[Enter steps to reproduce:]

1. a lot of unstaged files the node_modules folder that I didn't add it to .gitignore
2. given I am on the last file in the unstaged changes panel, when I press the arrow down key then the following message appears:

Atom: 1.21.0-beta0 x64
Electron: 1.6.9
OS: Mac OS X 10.12.6
Thrown From: github package 0.6.2

Stack Trace

Uncaught TypeError: Cannot read property 'scrollIntoViewIfNeeded' of undefined

At /Users/frank/.atom/packages/github/lib/views/staging-view.js:352

TypeError: Cannot read property 'scrollIntoViewIfNeeded' of undefined
    at StagingView.writeAfterUpdate (/packages/github/staging-view.js:352:21)
    at updateSync (/packages/github/node_modules/etch/lib/component-helpers.js:134:15)
    at /packages/github/node_modules/etch/lib/component-helpers.js:72:7
    at DefaultScheduler.performUpdates (/packages/github/node_modules/etch/lib/default-scheduler.js:48:34)

Commands

     -3:11.6.0 tree-view:show (atom-workspace.workspace.scrollbars-visible-when-scrolling)
     -3:04.5.0 editor:move-to-first-character-of-line (input.hidden-input)
     -3:03.0 core:save (input.hidden-input)
     -2:59.5.0 core:close (input.hidden-input)
     -2:57.9.0 core:move-right (atom-workspace.workspace.scrollbars-visible-when-scrolling.theme-cobalt2-syntax.theme-atom-dark-ui)
undefined -2:57.7.0 core:move-down (atom-workspace.workspace.scrollbars-visible-when-scrolling.theme-cobalt2-syntax.theme-atom-dark-ui)
undefined -2:47.1.0 core:move-up (div.github-StagingView.unstaged-changes-focused)
undefined -2:35.8.0 core:move-down (div.github-StagingView.unstaged-changes-focused)
     -1:23.9.0 core:copy (atom-notification.fatal.icon.icon-bug.native-key-bindings.has-detail.has-close.has-stack)

Non-Core Packages

asciidoc-preview 2.10.2 
atom-beautify 0.30.5 
atom-ctags 5.1.0 
atom-liquid-snippets 0.3.0 
atom-runner 2.7.1 
Atom-Syntax-highlighting-for-Sass 0.5.0 
atom-ternjs 0.18.3 
auto-update-packages 1.0.1 
autoclose-html 0.23.0 
autocomplete-emojis 2.5.0 
blame 0.12.0 
busy-signal 1.4.3 
caniuse 0.9.2 
cobalt2-syntax 0.5.1 
cucumber 0.6.0 
editorconfig 2.2.2 
elm-format 3.0.0 
emmet 2.4.3 
file-icons 2.1.12 
fonts 3.0.3 
gist 1.0.0 
git-plus 7.9.3 
guard-rspec 0.4.0 
hard-wrap 1.1.0 
highlight-selected 0.13.1 
inline-markdown-images 1.0.0 
intentions 1.1.5 
jekyll 2.1.0 
language-apache 1.7.0 
language-asciidoc 1.10.0 
language-elm 1.5.0 
language-hugo 0.3.1 
language-liquid 0.6.0 
language-markdown 0.25.1 
language-slim 0.6.0 
lebab 0.10.0 
linter 2.2.0 
linter-alex 4.0.0 
linter-csslint 2.0.0 
linter-htmlhint 1.3.3 
linter-js-yaml 1.2.7 
linter-json-lint 0.1.2 
linter-markdown 5.2.0 
linter-markdownlint 1.0.1 
linter-remark 5.0.0 
linter-rubocop 2.1.1 
linter-slim 1.0.0 
linter-stylelint 4.0.2 
linter-ui-default 1.6.10 
linter-write-good 0.9.0 
linter-xo 0.23.1 
markdown-lists 0.0.2 
markdown-writer 2.7.2 
mdn-doc 0.3.0 
merge-conflicts 1.4.5 
prettier-atom 0.40.0 
pretty-json 1.6.4 
react 0.16.2 
rubocop-auto-correct 1.5.1 
sort-lines 0.15.0 
standard-formatter 2.8.0 
stylefmt 5.0.1 
terminal-plus 0.14.5 
tidy-markdown 3.0.1 
travis-ci-status 1.3.1 
webbox-color 0.5.9 
wordcount 2.10.4 
yaml-sortkey 0.1.0 
Zen 0.18.0 

[rsese]

It seems related to the node_modules folder (adding the folder to .gitignore can even make the editor crash).

So it seems like the issue is specific to a particular project? I tried to reproduce with atom/atom but wasn't able to - can you reproduce with any other projects? If you can share a specific repo that we can try that would be great too.

adding the folder to .gitignore can even make the editor crash

Hmmm, not sure if that's related to this issue but it sounds like this isn't always reproducible? Is there a crash log you can share?

http://flight-manual.atom.io/hacking-atom/sections/debugging/#find-crash-logs

[DirtyF]

So it seems like the issue is specific to a particular project?

This happened before I add node_modules to .gitignore on the branch of this PR for Jekyll.