This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Stop propagation of handled focus events in tab view #1291
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents the Diagnostics panel from being focused
BinaryMuse
approved these changes
Jan 19, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1245.
Prior to this PR,
core:focus-nextandcore:focus-previouswhile in the Git panel would focus the Diagnostics panel, causing it to open if it was closed. This PR stops event propagation once they are handled by the Git panel and ensures that focus remains within the Git panel.Supersedes #1255. Thanks @xdissent for doing all of the heavy-lifting :)