Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Restyle hovercards #1593

Merged
merged 3 commits into from
Jul 19, 2018
Merged

Restyle hovercards #1593

merged 3 commits into from
Jul 19, 2018

Conversation

simurai
Copy link
Contributor

@simurai simurai commented Jul 19, 2018

Description of the Change

This restyles the "hovercards".

Before After
screen shot 2018-07-19 at 10 01 56 pm screen shot 2018-07-19 at 10 02 41 pm
screen shot 2018-07-19 at 10 02 57 pm screen shot 2018-07-19 at 10 03 23 pm

Alternate Designs

We could go closer to .com.

Benefits

  • Easier to read
  • Long PR titles don't get cut off

Also, there is now a github-Popover class that can be re-used for other tooltips.

Possible Drawbacks

Might not work with all themes the same.

Applicable Issues

None, this is a direct order from @donokuda
Part of #1503

@daviwil
Copy link
Contributor

daviwil commented Jul 19, 2018

Looks amazing! I love the subtle drop shadow

@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 79.524% when pulling 328e69f on sm/hovercard into ac4d3a1 on master.

1 similar comment
@coveralls
Copy link

coveralls commented Jul 19, 2018

Coverage Status

Coverage increased (+0.03%) to 79.524% when pulling 328e69f on sm/hovercard into ac4d3a1 on master.

@smashwilson smashwilson merged commit c0d5893 into master Jul 19, 2018
@smashwilson smashwilson deleted the sm/hovercard branch July 19, 2018 14:50
@simurai simurai mentioned this pull request Jul 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants