Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restyle hovercards #1593

Merged
merged 3 commits into from Jul 19, 2018

Conversation

4 participants
@simurai
Copy link
Member

simurai commented Jul 19, 2018

Description of the Change

This restyles the "hovercards".

Before After
screen shot 2018-07-19 at 10 01 56 pm screen shot 2018-07-19 at 10 02 41 pm
screen shot 2018-07-19 at 10 02 57 pm screen shot 2018-07-19 at 10 03 23 pm

Alternate Designs

We could go closer to .com.

Benefits

  • Easier to read
  • Long PR titles don't get cut off

Also, there is now a github-Popover class that can be re-used for other tooltips.

Possible Drawbacks

Might not work with all themes the same.

Applicable Issues

None, this is a direct order from @donokuda
Part of #1503

@daviwil

This comment has been minimized.

Copy link
Member

daviwil commented Jul 19, 2018

Looks amazing! I love the subtle drop shadow

@coveralls

This comment has been minimized.

Copy link

coveralls commented Jul 19, 2018

Coverage Status

Coverage increased (+0.03%) to 79.524% when pulling 328e69f on sm/hovercard into ac4d3a1 on master.

1 similar comment
@coveralls

This comment has been minimized.

Copy link

coveralls commented Jul 19, 2018

Coverage Status

Coverage increased (+0.03%) to 79.524% when pulling 328e69f on sm/hovercard into ac4d3a1 on master.

@smashwilson smashwilson merged commit c0d5893 into master Jul 19, 2018

4 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.03%) to 79.524%
Details

@smashwilson smashwilson deleted the sm/hovercard branch Jul 19, 2018

@simurai simurai referenced this pull request Jul 20, 2018

Merged

Restyle hovercards II #1601

@smashwilson smashwilson added this to In Progress 🔧 in Stability Sprint : 23 July - 3 August 2018 : v0.19.0 via automation Aug 13, 2018

@smashwilson smashwilson moved this from In Progress 🔧 to Merged ☑️ in Stability Sprint : 23 July - 3 August 2018 : v0.19.0 Aug 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.