Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Conversation

phynalle
Copy link
Contributor

Description of the Change

Some parameters inside pseudo class dir haven't been colorized. It's trivial but it should be fixed.
The reason is the mistypo of pattern name and I just fixed it.

Alternate Designs

None

Benefits

We can see pattern colorizing inside dir pseudo class as intended.

Possible Drawbacks

None

Applicable Issues

None

It's trivial but it should be fixed.
@winstliu
Copy link
Contributor

Thanks! Could you add some specs to this as well?

@phynalle
Copy link
Contributor Author

What kind of spec do you need? I think the description is enough because I just corrected a mistypo.

@winstliu
Copy link
Contributor

I mean specs as in tests: http://flight-manual.atom.io/hacking-atom/sections/writing-specs/
You add them to this file.

@phynalle
Copy link
Contributor Author

I think specs should be remained.
I fixed ignoring some patterns which colorize parameter of :dir().
In current spec file, I think the specs about it are all written. So no additional spec is needed.
That is also the reason why the misspelling haven't been discovered.
Well, I can put any specs related to patterns I corrected but they wouldn't be allowed in css grammar.

@winstliu winstliu merged commit d982430 into atom:master Dec 16, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants