This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Class member with visibility modifier and arrays #118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I fixed the code to fulfill the spec so let me know please. |
sadikovi
approved these changes
Dec 26, 2017
|
Here are the tests! I added them in the class fields test. |
|
LGTM. Thanks for the tests. @50Wliu would you mind having a look at this? Thanks! |
winstliu
approved these changes
Dec 31, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Description of the Change
Change to correct bug of #116 , arrays are now correctly detected as a type.
Alternate Designs
Benefits
Correct syntax highlight for array as type.
Possible Drawbacks
Applicable Issues
#116