Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Conversation

sadikovi
Copy link
Contributor

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions

Description of the Change

This PR adds reserved keywords const and goto, so they are highlighted as standard keywords, e.g. try or catch, or instanceof. I assigned scope keyword.reserved.java for them, because I could not figure out what existing scope they should belong to, since they are not used:).

Looks like this now:
after

Alternate Designs

None were considered, because it is fairly simple change.

Benefits

Reserved keywords are now highlighted the same way as standard keywords.

Possible Drawbacks

None.

Applicable Issues

#136

@sadikovi
Copy link
Contributor Author

@50Wliu Could you review this PR? Let me know if it should be added like this or we should add those keywords into one of the existing scopes. Thanks!

Copy link
Contributor

@winstliu winstliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. I love the addition of reserved, so that themes can style that how they wish.

@sadikovi
Copy link
Contributor Author

Thanks @50Wliu! Will merge.

@sadikovi sadikovi merged commit 9c7182e into atom:master Mar 13, 2018
@sadikovi sadikovi deleted the const-goto-keywords branch March 13, 2018 18:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants