New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reserved keywords #137

Merged
merged 1 commit into from Mar 13, 2018

Conversation

Projects
None yet
2 participants
@sadikovi
Member

sadikovi commented Mar 13, 2018

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions

Description of the Change

This PR adds reserved keywords const and goto, so they are highlighted as standard keywords, e.g. try or catch, or instanceof. I assigned scope keyword.reserved.java for them, because I could not figure out what existing scope they should belong to, since they are not used:).

Looks like this now:
after

Alternate Designs

None were considered, because it is fairly simple change.

Benefits

Reserved keywords are now highlighted the same way as standard keywords.

Possible Drawbacks

None.

Applicable Issues

#136

@sadikovi

This comment has been minimized.

Member

sadikovi commented Mar 13, 2018

@50Wliu Could you review this PR? Let me know if it should be added like this or we should add those keywords into one of the existing scopes. Thanks!

@50Wliu

50Wliu approved these changes Mar 13, 2018

Awesome. I love the addition of reserved, so that themes can style that how they wish.

@sadikovi

This comment has been minimized.

Member

sadikovi commented Mar 13, 2018

Thanks @50Wliu! Will merge.

@sadikovi sadikovi merged commit 9c7182e into atom:master Mar 13, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@sadikovi sadikovi deleted the sadikovi:const-goto-keywords branch Mar 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment