This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Fix grammar to validate JSON numbers. #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
changed the title
ghost
mentioned this pull request
kevinsawicki
added a commit
that referenced
this pull request
Feb 3, 2015
Fix grammar to validate JSON numbers.
Contributor
|
Cool, thanks for tightening this up |
Author
|
😄 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#9
The correct regular expression using lookaheads and lookbehinds is:
The comments were removed as I couldn't figure out a sane way to squash everything into a single string. Perhaps this grammar was copied verbatim from the TextMate bundle? using some sort of automated tool.
Anyway, maybe it would be more useful to have a separate file with comments for all the regular expressions. What do you think?
Source