New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'lcie' prefix was 'else condition' when it should have been 'else value' #260

Merged
merged 1 commit into from May 31, 2018

Conversation

Projects
None yet
2 participants
@creech46

creech46 commented May 31, 2018

Description of the Change

Currently when you type in lcie to autocomplete a list comprehension if else it autocompletes it to '[value if condition else condition for value in variable]'. But it should actually be '[value if condition else value for value in variable]' since you are specifying an alternative value after the 'else' and not specifying another condition.

Alternate Designs

There are not any other reasonable ways to make this change.

Benefits

The list comprehension if else auto-completion will be clearer.

Possible Drawbacks

None

Applicable Issues

None

@50Wliu

This comment has been minimized.

Member

50Wliu commented May 31, 2018

CI failure is unrelated. Thanks for the PR!

@50Wliu 50Wliu merged commit fc9dd3b into atom:master May 31, 2018

1 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment