This repository was archived by the owner on Dec 15, 2022. It is now read-only.
'lcie' prefix was 'else condition' when it should have been 'else value' #260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI failure is unrelated. Thanks for the PR! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Currently when you type in lcie to autocomplete a list comprehension if else it autocompletes it to '[value if condition else condition for value in variable]'. But it should actually be '[value if condition else value for value in variable]' since you are specifying an alternative value after the 'else' and not specifying another condition.
Alternate Designs
There are not any other reasonable ways to make this change.
Benefits
The list comprehension if else auto-completion will be clearer.
Possible Drawbacks
None
Applicable Issues
None