This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Add proper commenting for jsx #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution. These files are a copy from the upstream source https://github.com/Microsoft/TypeScript-TmLanguage and we don't want to get out of step as it makes taking changes from upstream more painful. I would recommend you send a PR to that repository to fix it there so that all repositories that base their grammar on there get the improvement including this one! Thanks! |
|
Are settings also copied from there? |
|
Sorry yes, you are right these are snippets not grammar! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comments in JSX should be handled differently, this PR fixes that.