This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Make loaded
an instance variable
#259
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Description of the Change
Before,
loaded
was a global variable. This meant that once it was set to true it would stay true forever, even after deactivating and reactivating snippets. This PR changes it to an instance variable so that its state is reset correctly across activations.Alternate Designs
None.
Benefits
This makes the
bundledSnippetsLoaded
method ofprovideSnippets()
much more reliable, as previously it would return the wrong value if snippets was deactivated then reactivated.Possible Drawbacks
None.
Applicable Issues
Refs atom/settings-view#998, in which I have been experimenting with using
bundledSnippetsLoaded
.