This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Reduce the memory impact of leaking destroyed objects #193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nathan Sobo <nathan@github.com>
Signed-off-by: Nathan Sobo <nathan@github.com>
This was referenced Jan 3, 2017
maxbrunsfeld
added a commit
to atom/whitespace
that referenced
this pull request
Jan 3, 2017
This is now explicitly forbidden. See atom/text-buffer#193
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tear down
TextBuffer,DisplayLayer,Markerand friends more aggressively so that if these objects are leaked (e.g. due to bugs in Atom packages), they will use less memory.🍐'd with @nathansobo